Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device-viewer | Docs | Testing and Documentation for device-viewer component #1238

Merged
merged 5 commits into from
Aug 5, 2019
Merged

Device-viewer | Docs | Testing and Documentation for device-viewer component #1238

merged 5 commits into from
Aug 5, 2019

Conversation

TashaBasalt
Copy link
Contributor

@TashaBasalt TashaBasalt commented Jun 28, 2019 •
edited by joekarasek
Loading

Jira

http://vjira2:8080/browse/BDS-942

Summary

Adding testing for device-viewer component

Details

Adding Jest snapshot tests and TESTING.md File

How to test

yarn test:js

@joekarasek
Copy link
Contributor

@mikemai2awesome @TashaBasalt I have two questions for Mike/Pega team on this one (tagging Tasha so she sees the convo).

  1. Should the web-component/disable JS testing.md section include or mention a magnification variation? It does not fully function (some basic overlay and hover effect is there, but no magnifying glass.

  2. For the snapshot tests, how extensively should we be testing all the various patterns. For example, should be testing every color varation of every device, or is the current testing representative enough? I imagine that some combo's don't work/ don't make sense (i.e. they don't make a white/black variation of the macbook).

mikemai2awesome
mikemai2awesome requested changes Jul 15, 2019
View reviewed changes
Copy link
Collaborator

@mikemai2awesome mikemai2awesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joekarasek I think these tests will do. Just see my inline comment for one change.

packages/components/bolt-device-viewer/__tests__/device-viewer.js Outdated Show resolved Hide resolved
@margoromo margoromo requested a review from sghoweri July 16, 2019 13:20
mikemai2awesome
mikemai2awesome approved these changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@mikemai2awesome mikemai2awesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

sghoweri
sghoweri approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys!

@sghoweri sghoweri mentioned this pull request Aug 5, 2019
Merged
@sghoweri sghoweri merged commit 2c2aef3 into master Aug 5, 2019
@sghoweri sghoweri deleted the feature/device-viewer branch August 5, 2019 13:22
@sghoweri sghoweri mentioned this pull request Aug 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemai2awesome mikemai2awesome mikemai2awesome approved these changes

@sghoweri sghoweri sghoweri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TashaBasalt @joekarasek @sghoweri @mikemai2awesome